feat(W-23159740): use per-user UA string in SFHybridViewController#314
Merged
wmathurin merged 3 commits intoJun 29, 2026
Merged
Conversation
Passes current user to userAgentString:qualifier:forUser: so per-user feature flags appear in the User-Agent for hybrid views.
|
||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #314 +/- ##
==========================================
- Coverage 62.61% 62.57% -0.05%
==========================================
Files 20 20
Lines 1688 1686 -2
==========================================
- Hits 1057 1055 -2
Misses 631 631
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
bbirman
approved these changes
Jun 25, 2026
Contributor
Author
|
NB: Once the iOS PR forcedotcom/SalesforceMobileSDK-iOS#4086 is merged, I will update the submodule here and the tests should build and pass again. |
|
||||||||||||||
Resolve submodule conflict in external/SalesforceMobileSDK-iOS by keeping our SHA (99a173b) which includes the per-user feature flag changes (forcedotcom/SalesforceMobileSDK-iOS#4086). Upstream had 2692236.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SFHybridViewController.m: passescurrentUsertouserAgentString:qualifier:forUser:so per-user feature flags are included in the hybrid WebView User-Agent stringGUS Stories
Dependencies
Test plan